Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): improve behaviour of dict-expansion (scalars) when mixed with numpy arrays #6663

Merged

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Feb 3, 2023

  • Slightly reworked dict_to_pydf to fix an issue on array-expansion of scalars when mixed with large numpy array column data (wasn't taking the multi-threaded loading codepath).
  • Extended related unit tests to include numpy data and ensure that both codepaths receive branch coverage.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Feb 3, 2023
@ritchie46 ritchie46 merged commit 199f39c into pola-rs:master Feb 3, 2023
@alexander-beedie alexander-beedie deleted the mixed-numpy-dict-expansion branch February 3, 2023 21:12
Vincenthays pushed a commit to Vincenthays/polars that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants